Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add toolchain param to the affected actions #2271

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add toolchain param to the affected actions #2271

wants to merge 1 commit into from

Conversation

kotlaja
Copy link

@kotlaja kotlaja commented Aug 31, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • [ x] Other... Please describe: This is a step forward for the migration of Automatic Exec Groups. Each action which uses tool/executable should add a toolchain param.

What is the current behavior?

Exec platform selection is on a rule level. Which means that a rule can have one default execution platform, unless specified differently via exec_groups.

Issue Number: N/A

What is the new behavior?

Exec platform selection is on a toolchain_type level. Which means that each action on a rule can have a different execution platform.

Does this PR introduce a breaking change?

  • Yes
  • [ x ] No - Not for now since AEGs are still disabled in Bazel. Once they becom enabled, you will have more information connected to possible errors (issue description on github and incompatible flag).

Other information

@kotlaja
Copy link
Author

kotlaja commented Aug 31, 2023

Oh, I see that you're using Bazel 4.0. Is there a possibility to update it to Bazel 6.0? toolchain param is available from 6.0. onwards.

@github-actions GitHub Actions
Copy link

This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days.
Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_docker!

@github-actions github-actions bot added the Can Close? Will close in 30 days unless there is a comment indicating why not label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gravypod gravypod Awaiting requested review from gravypod gravypod is a code owner

@linzhp linzhp Awaiting requested review from linzhp linzhp is a code owner

@pcj pcj Awaiting requested review from pcj pcj is a code owner

@smukherj1 smukherj1 Awaiting requested review from smukherj1 smukherj1 is a code owner

@uhthomas uhthomas Awaiting requested review from uhthomas uhthomas is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Can Close? Will close in 30 days unless there is a comment indicating why not
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kotlaja